feat!: update to new course outline structure and design#115
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
8e921e2 to
d7de0cc
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
===========================================
+ Coverage 53.25% 73.56% +20.30%
===========================================
Files 15 13 -2
Lines 338 348 +10
Branches 67 76 +9
===========================================
+ Hits 180 256 +76
+ Misses 149 84 -65
+ Partials 9 8 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2f0eabb to
f491f64
Compare
Thanks for the info @ChrisChV! I improved the coverage a bit, but we may also need more time to make it cover all features. This was tricky because we use data from the CourseAuthoring package here, but we don't have it installed, so we had to mock it. |
|
Hi @saraburns1 / @bmtcril ! Thanks! 😄 |
|
Hi @rpenido ! Couple things from my testing:
|
|
Thanks for the review @saraburns1!
This one is a bit trickier since we are using the new sidebar, which is always sticky at the top. I don't think we can make it work differently for the Aspects page. Maybe we can try to make the whole sidebar fixed on the view height with a scrollbar, but it may have other implications. CC @sdaitzman @edschema @ChrisChV
Good catch! Just to confirm, when you say "subsection" here, you mean "unit", right?
I fixed that in openedx/frontend-app-authoring#2969 |
Hmm. @bmtcril @crathbun428 - what are your thoughts on this? Is it better to not scroll the page at all? Or keep the scroll-to-unit and then have to scroll back to the top of the page to see the analytics? |
|
I think we will have the same problem when it comes to tags, of needing some kind of sidebar that stays in place with the context of what the user clicked. Tags currently overlay the regular sidebar with a different looking and larger sidebar modal, which isn't great and I know was on the list of things to fix, but I think whatever solution we come up with should be reusable for both and any other future in-context cases. |
|
Hi @bmtcril and @saraburns1! |
|
I'm trying to understand what changes were made in Looking through the plugin slots mentioned in the testing block of the PR description:
Looking through the diff for this PR, it's not fully clear to me what changes are being made because they are needed for the plugin to continue to work vs what changes are being made to utilize new functionality from My main concern is that something may have landed in With that in mind, the questions I'd like to see answers to are:
|
The changes in this PR are to move the aspects sidebar to a new page within the current sidebar, rather than overriding it.
The plugin is rendered over the sidebar, as expected. The user may have some erratic behavior on some features (from the authoring side, not aspects) which were moved to the sidebar: i.e. Tagging, Adding Content, etc.. |
If I'm understanding this correctly this means it is moving to a new page within the new (non-legacy) sidebar. That means that everyone using a version of this plugin with these changes will need to be using a version of |
|
Hi @saraburns1! Sorry for the ping, but is there anything blocking this from being merged? 😄 |
|
@rpenido can you change the version number in package.json to 3.0.0? then i'll merge |
Sure, but isn't the version applied on release? frontend-plugin-aspects/package.json Line 3 in 0c87bf0 |
|
it doesn't get updated on release, we need to do it manually - and it was never done for v2 so we should just do it now |
|
Thanks for the clarification @saraburns1! |
|
@rpenido one more thing, can you fix the 'branch out of date' error? it won't let me merge |
|
Thanks @saraburns1!! |
|
@rpenido why does the sidebar look like this in the master sandbox? should there have been a feature toggle or something? |
|
Hi @saraburns1! We are removing these flags and making the new design default as part of openedx/frontend-app-authoring#2879 |
|
is the plan to enable this for Verawood? |
|
@saraburns1 Yes! |
|
Thank you!
…On Thu, Apr 23, 2026 at 2:31 PM Rômulo Penido ***@***.***> wrote:
*rpenido* left a comment (openedx/frontend-plugin-aspects#115)
<#115?email_source=notifications&email_token=BIR4DO4SPTM5PF3B6MGLX4T4XJORDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZQGY4DGNRYGIZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4306836823>
@saraburns1 <https://github.com/saraburns1> Yes!
—
Reply to this email directly, view it on GitHub
<#115?email_source=notifications&email_token=BIR4DO4SPTM5PF3B6MGLX4T4XJORDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZQGY4DGNRYGIZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4306836823>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIR4DO55FLYV4NRQ2LUBDGL4XJORDAVCNFSM6AAAAACR67V6ZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMBWHAZTMOBSGM>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BIR4DOYZR4L7MTQL3IXBKTL4XJORDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZQGY4DGNRYGIZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BIR4DO7PPSJTYREJFMVXESD4XJORDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZQGY4DGNRYGIZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|


Description
This PR updates the plugin structure to the new sidebar design.
For now, it only works for the Course Outline page.
Additional Information
Related to:
Depends on:
Testing Instructions
Setup
maintutor plugin will install a fixed version from the frontend plugin.env.config.jsxwith the wrap plugin like below:npm installon the frontend folder to update thefrontend-plugin-frameworkversion. If you are not seeing the plugin icon, you can trynpm install ./frontend-plugin-aspects; npm run build;from thefrontend-app-authoringfolder.NOTE: The Aspects use some LMS APIs to check the course structure, so make sure you have all your course components published before testing. You need to have some units with
ProblemsandVideosxblocks (the ones shown in aspects). You also need at least one Graded Subsection (i.e.Three dot menu from subsection card > Configure > Graded as: Homework).Testing Course Outline
Testing Unit Outline
ProblemorVideoXBlocks.Private ref: FAL-4305